Is this a mistake in CVS source?

Mar 14, 2011, 3:58 am

#1

archangel

Joined: Sep 8, 2010
Occupation: Petty Functionary
Location: Drinking pea soup in the world map
Interests: Mangoes
Posts: 1,216

In char.cpp at the bottom:

void character::Slow()
{
  doforbodyparts()(this, &bodypart::Slow);
  doforequipments()(this, &item::Slow);
  BeginTemporaryState(HASTE, 500 + RAND() % 1000);
}

When Slow() is called, it will slow equipments and bodyparts, but activate Haste as a temporary state. Should it instead be:

void character::Slow()
{
  doforbodyparts()(this, &bodypart::Slow);
  doforequipments()(this, &item::Slow);
  BeginTemporaryState(SLOW, 500 + RAND() % 1000);
}

?

Either an elder dark mage, or

should be able to verify that this is a bug, when they cast "slow" on the player.

Batman? wrote

its been so long since i had gotten that far i didnt think it through. arrrr!!!!!!

Mar 14, 2011, 5:41 am

#2

angel

Joined: Jan 25, 2008
Occupation: Turns out I can't have a cool avatar, I'll just put crap in it.
Location: 48kg / 105 lbs
Interests: My name is Failbert
Posts: 697

Knowing the twisty twists and uncommented code of IVAN, this might as well be a deliberate feature (maybe so that slows don't stack their effect, or something?). But yeah, gotta change 'haste' to 'slow' and do the testing.

Well I assume that a bolt has a given, numeric, amouunt of perwer. (assi in enegri)... unless it's LAERSER SKISKLS POEWN PEWN!

Mar 14, 2011, 7:34 am

#3

Mage Prophet

Joined: Dec 3, 2007
Occupation: Chaos Weaver
Location: Standing between all life and death
Posts: 2,898

Looks to me like that's the bug that causes wands of slow to haste targets instead.

Uchuudonge wrote

creating stable chaos
making patterns where there should be none
sewing order into the chaos
you spit in the face of random numbers, of chaos

Mar 14, 2011, 3:35 pm

#4

kobold lord

Joined: Dec 15, 2010
Interests: mutant ass
Posts: 100

chaostrom wrote

Looks to me like that's the bug that causes wands of slow to haste targets instead.

Well maybe it's not a bug. Time is relative after all.

Mar 14, 2011, 5:32 pm

#5

archangel

Joined: Sep 8, 2010
Occupation: Petty Functionary
Location: Drinking pea soup in the world map
Interests: Mangoes
Posts: 1,216

That's funny. Wands of slow behave differently in 0.50 to the wands of slow in CVS.

Batman? wrote

its been so long since i had gotten that far i didnt think it through. arrrr!!!!!!

Mar 14, 2011, 6:07 pm

#6

Ex-Tyrant of the IVANers

Joined: Dec 8, 2007
Occupation: Junior Scientist
Location: Not California
Interests: Physics and Astronomy, Exoplanets, Singing praise to Valpurus while smashing skulls with a bloody warhammer, Jogging
Posts: 2,920

The devs may have been testing something.

"Put more stuff in the... thing where... more stuff goes in."

Mar 14, 2011, 9:15 pm

#7

Mage Prophet

Joined: Dec 3, 2007
Occupation: Chaos Weaver
Location: Standing between all life and death
Posts: 2,898

Whatever their intentions were, it's a well known bug that wands of slow in CVS haste things instead.

Uchuudonge wrote

creating stable chaos
making patterns where there should be none
sewing order into the chaos
you spit in the face of random numbers, of chaos

Mar 14, 2011, 11:23 pm

#8

archangel

Joined: Sep 8, 2010
Occupation: Petty Functionary
Location: Drinking pea soup in the world map
Interests: Mangoes
Posts: 1,216

I like to think the bugs are semi-intentional. There's another one in confdef.h:

#define ANTITODE_LIQUID (LIQUID_ID + 9)

Should read

#define ANTIDOTE_LIQUID (LIQUID_ID + 9)

Antitoad... maybe it's a pun?

Batman? wrote

its been so long since i had gotten that far i didnt think it through. arrrr!!!!!!