Is this a mistake in CVS source?

https://attnam.com/topics/Is-this-a-mistake-in-CVS-source

The Cathedral of Attnam > Trouble Shooting and Bugs

#1 Mar 14, 2011, 3:58 am Hide

fejoa

In char.cpp at the bottom:

void character::Slow()
{
  doforbodyparts()(this, &bodypart::Slow);
  doforequipments()(this, &item::Slow);
  BeginTemporaryState(HASTE, 500 + RAND() % 1000);
}

When Slow() is called, it will slow equipments and bodyparts, but activate Haste as a temporary state. Should it instead be:

void character::Slow()
{
  doforbodyparts()(this, &bodypart::Slow);
  doforequipments()(this, &item::Slow);
  BeginTemporaryState(SLOW, 500 + RAND() % 1000);
}
?

Either an elder dark mage, or should be able to verify that this is a bug, when they cast "slow" on the player.
#2 Mar 14, 2011, 5:41 am Hide

Alveradok

Knowing the twisty twists and uncommented code of IVAN, this might as well be a deliberate feature (maybe so that slows don't stack their effect, or something?). But yeah, gotta change 'haste' to 'slow' and do the testing.
#3 Mar 14, 2011, 7:34 am Hide

chaostrom

Looks to me like that's the bug that causes wands of slow to haste targets instead.
#4 Mar 14, 2011, 3:35 pm Hide

cowofdoom78963

chaostrom wrote
Looks to me like that's the bug that causes wands of slow to haste targets instead.
Well maybe it's not a bug. Time is relative after all.
#5 Mar 14, 2011, 5:32 pm Hide

fejoa

That's funny. Wands of slow behave differently in 0.50 to the wands of slow in CVS.
#6 Mar 14, 2011, 6:07 pm Hide

Ischaldirh

The devs may have been testing something.
#7 Mar 14, 2011, 9:15 pm Hide

chaostrom

Whatever their intentions were, it's a well known bug that wands of slow in CVS haste things instead.
#8 Mar 14, 2011, 11:23 pm Hide

fejoa

I like to think the bugs are semi-intentional. There's another one in confdef.h:

#define ANTITODE_LIQUID (LIQUID_ID + 9)

Should read

#define ANTIDOTE_LIQUID (LIQUID_ID + 9)

Antitoad... maybe it's a pun?