Warheck wrote
[…] is it ok if we stick to "
BSD style", with two-space indentation?
Yes, those, no tabs, and any other consistencies we can find in the original source code, off the top of my head:
* no braces for 'if's, 'while's, etc. if they contain only one statement
* no space between 'if', 'while', etc., and the following '('
* 'lowercasewithoutunderscores' for type names, 'PascalCase' for variable names
* no space between type name and '*' / '&' in variable declarations
* comments start with a capital letter
There are also some inconsistencies that we should probably fix. For example sometimes '&' and '|' have no space around them but there's also lots of code with spaces around them. I think they're more readable with spaces.
Maximum line width? There are some ridiculously long lines that don't really contribute to readability. Would something like 90 or 100 be good? With 90 I can fit two pages of code side by side in my editor which is really handy.